Skip to content

Allow removing all application owners and labels #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asafgabai merged 2 commits into from
Aug 27, 2025
Merged

Allow removing all application owners and labels #36

asafgabai merged 2 commits into from
Aug 27, 2025

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Aug 26, 2025 •
edited
Loading

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Allow removing all user owners, group owners and labels of an application using the application-update command

@asafgabai asafgabai added bug Something isn't working safe to test Approve running end-to-end tests on a pull request labels Aug 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025 •
edited
Loading

Unit Tests Results

182 tests  ±0   182 ✅ ±0   0s ⏱️ ±0s
 25 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d0e6457. ± Comparison against base commit 1ab9a89.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. 
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/full_spec_file

github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_FullSpecFile

♻️ This comment has been updated with latest results.

@asafgabai asafgabai marked this pull request as ready for review August 27, 2025 07:02
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

EyalDelarea
EyalDelarea suggested changes Aug 27, 2025
View reviewed changes
@asafgabai asafgabai merged commit c958c10 into main Aug 27, 2025
6 checks passed
@asafgabai asafgabai deleted the allow-remove-all-owners branch August 27, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EyalDelarea EyalDelarea EyalDelarea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asafgabai @EyalDelarea